<p>Werner Zeh <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/20463">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">smbios: Correct the system enclosure types<br><br>Regarding the "System Management BIOS Reference Specification"<br>Version: 3.1.1, Date: 2017-01-12, Laptop system enclosure is 0x09<br>and for Notebook it is 0x0a<br><br>Change-Id: I5538be0b434eed20d76aef6f26247e46d1225feb<br>Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr><br>Reviewed-on: https://review.coreboot.org/20463<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Martin Roth <martinroth@google.com><br>---<br>M src/arch/x86/smbios.c<br>M src/include/smbios.h<br>2 files changed, 37 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c<br>index 97c5881..79279fa 100644<br>--- a/src/arch/x86/smbios.c<br>+++ b/src/arch/x86/smbios.c<br>@@ -426,7 +426,7 @@<br>    t->power_supply_state = SMBIOS_STATE_SAFE;<br>         t->thermal_state = SMBIOS_STATE_SAFE;<br>      if (IS_ENABLED(CONFIG_SYSTEM_TYPE_LAPTOP))<br>-           t->_type = SMBIOS_ENCLOSURE_NOTEBOOK;<br>+             t->_type = SMBIOS_ENCLOSURE_LAPTOP;<br>        else<br>          t->_type = SMBIOS_ENCLOSURE_DESKTOP;<br>       t->security_status = SMBIOS_STATE_SAFE;<br>diff --git a/src/include/smbios.h b/src/include/smbios.h<br>index 5a9ef37..28f8d13 100644<br>--- a/src/include/smbios.h<br>+++ b/src/include/smbios.h<br>@@ -278,8 +278,42 @@<br> } __attribute__((packed));<br> <br> enum {<br>-   SMBIOS_ENCLOSURE_DESKTOP = 3,<br>-        SMBIOS_ENCLOSURE_NOTEBOOK = 9,<br>+       SMBIOS_ENCLOSURE_OTHER = 0x01,<br>+       SMBIOS_ENCLOSURE_UNKNOWN = 0x02,<br>+     SMBIOS_ENCLOSURE_DESKTOP = 0x03,<br>+     SMBIOS_ENCLOSURE_LOW_PROFILE_DESKTOP = 0x04,<br>+ SMBIOS_ENCLOSURE_PIZZA_BOX = 0x05,<br>+   SMBIOS_ENCLOSURE_MINI_TOWER = 0x06,<br>+  SMBIOS_ENCLOSURE_TOWER = 0x07,<br>+       SMBIOS_ENCLOSURE_PORTABLE = 0x08,<br>+    SMBIOS_ENCLOSURE_LAPTOP = 0x09,<br>+      SMBIOS_ENCLOSURE_NOTEBOOK = 0x0a,<br>+    SMBIOS_ENCLOSURE_HAND_HELD = 0x0b,<br>+   SMBIOS_ENCLOSURE_DOCKING_STATION = 0x0c,<br>+     SMBIOS_ENCLOSURE_ALL_IN_ONE = 0x0d,<br>+  SMBIOS_ENCLOSURE_SUB_NOTEBOOK = 0x0e,<br>+        SMBIOS_ENCLOSURE_SPACE_SAVING = 0x0f,<br>+        SMBIOS_ENCLOSURE_LUNCH_BOX = 0x10,<br>+   SMBIOS_ENCLOSURE_MAIN_SERVER_CHASSIS = 0x11,<br>+ SMBIOS_ENCLOSURE_EXPANSION_CHASSIS = 0x12,<br>+   SMBIOS_ENCLOSURE_SUBCHASSIS = 0x13,<br>+  SMBIOS_ENCLOSURE_BUS_EXPANSION_CHASSIS = 0x14,<br>+       SMBIOS_ENCLOSURE_PERIPHERAL_CHASSIS = 0x15,<br>+  SMBIOS_ENCLOSURE_RAID_CHASSIS = 0x16,<br>+        SMBIOS_ENCLOSURE_RACK_MOUNT_CHASSIS = 0x17,<br>+  SMBIOS_ENCLOSURE_SEALED_CASE_PC = 0x18,<br>+      SMBIOS_ENCLOSURE_MULTI_SYSTEM_CHASSIS = 0x19,<br>+        SMBIOS_ENCLOSURE_COMPACT_PCI = 0x1a,<br>+ SMBIOS_ENCLOSURE_ADVANCED_TCA = 0x1b,<br>+        SMBIOS_ENCLOSURE_BLADE = 0x1c,<br>+       SMBIOS_ENCLOSURE_BLADE_ENCLOSURE = 0x1d,<br>+     SMBIOS_ENCLOSURE_TABLET = 0x1e,<br>+      SMBIOS_ENCLOSURE_CONVERTIBLE = 0x1f,<br>+ SMBIOS_ENCLOSURE_DETACHABLE = 0x20,<br>+  SMBIOS_ENCLOSURE_IOT_GATEWAY = 0x21,<br>+ SMBIOS_ENCLOSURE_EMBEDDED_PC = 0x22,<br>+ SMBIOS_ENCLOSURE_MINI_PC = 0x23,<br>+     SMBIOS_ENCLOSURE_STICK_PC = 0x24,<br> };<br> <br> struct smbios_type3 {<br></pre><p>To view, visit <a href="https://review.coreboot.org/20463">change 20463</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20463"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I5538be0b434eed20d76aef6f26247e46d1225feb </div>
<div style="display:none"> Gerrit-Change-Number: 20463 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>