<p>Duncan Laurie has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20428">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/eve: Implement EC device events for S3 wake<br><br>Add support for waking from and logging device events that<br>originate in the Embedded Controller.  As this device uses<br>Deep S3 it relies on the EC to wake the AP from the trackpad<br>and DSP wake sources.<br><br>BUG=b:30624430<br>TEST=manual testing on Eve: wake from Deep S3 via trackpad and<br>DSP and verify the event log contains the expected device event.<br><br>Change-Id: I0d6a9c5bfd4cea85e13446ffaa6fe3dab0db96a2<br>Signed-off-by: Duncan Laurie <dlaurie@chromium.org><br>---<br>M src/mainboard/google/eve/ec.c<br>M src/mainboard/google/eve/ec.h<br>M src/mainboard/google/eve/smihandler.c<br>3 files changed, 12 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/20428/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/google/eve/ec.c b/src/mainboard/google/eve/ec.c<br>index 868714a..d5710f3 100644<br>--- a/src/mainboard/google/eve/ec.c<br>+++ b/src/mainboard/google/eve/ec.c<br>@@ -24,6 +24,10 @@<br>            google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS |<br>                                     MAINBOARD_EC_S3_WAKE_EVENTS);<br> <br>+          /* Log and clear device events that may wake the system */<br>+           google_chromeec_log_device_events(<br>+                   MAINBOARD_EC_S3_DEVICE_EVENTS);<br>+<br>            /* Disable SMI and wake events */<br>             google_chromeec_set_smi_mask(0);<br> <br>diff --git a/src/mainboard/google/eve/ec.h b/src/mainboard/google/eve/ec.h<br>index fa0dc21..81d591c 100644<br>--- a/src/mainboard/google/eve/ec.h<br>+++ b/src/mainboard/google/eve/ec.h<br>@@ -48,6 +48,7 @@<br> /* EC can wake from S3 with lid or power button or key press */<br> #define MAINBOARD_EC_S3_WAKE_EVENTS \<br>         (MAINBOARD_EC_S5_WAKE_EVENTS |\<br>+       EC_HOST_EVENT_MASK(EC_HOST_EVENT_DEVICE) |\<br>   EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED))<br> <br> /* Log EC wake events plus EC shutdown events */<br>@@ -56,6 +57,11 @@<br>      EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_SHUTDOWN) |\<br>         EC_HOST_EVENT_MASK(EC_HOST_EVENT_PANIC))<br> <br>+/* EC device events to enable and log in S3 */<br>+#define MAINBOARD_EC_S3_DEVICE_EVENTS \<br>+      (EC_DEVICE_EVENT_MASK(EC_DEVICE_EVENT_TRACKPAD) |\<br>+    EC_DEVICE_EVENT_MASK(EC_DEVICE_EVENT_DSP))<br>+<br> /*<br>  * ACPI related definitions for ASL code.<br>  */<br>diff --git a/src/mainboard/google/eve/smihandler.c b/src/mainboard/google/eve/smihandler.c<br>index 493a334..f51248c 100644<br>--- a/src/mainboard/google/eve/smihandler.c<br>+++ b/src/mainboard/google/eve/smihandler.c<br>@@ -36,6 +36,8 @@<br> {<br>     chromeec_smi_sleep(slp_typ, MAINBOARD_EC_S3_WAKE_EVENTS,<br>                         MAINBOARD_EC_S5_WAKE_EVENTS);<br>+     chromeec_smi_device_event_sleep(slp_typ,<br>+                                     MAINBOARD_EC_S3_DEVICE_EVENTS, 0);<br>    mainboard_gpio_smi_sleep(slp_typ);<br> }<br> <br></pre><p>To view, visit <a href="https://review.coreboot.org/20428">change 20428</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20428"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I0d6a9c5bfd4cea85e13446ffaa6fe3dab0db96a2 </div>
<div style="display:none"> Gerrit-Change-Number: 20428 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org> </div>