<p>Duncan Laurie has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20433">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/gooogle/eve: Interrupt changes for audio devices<br><br>Use the new PAD_CFG_GPI_INT macro to specify the headset codec<br>interrupt as specifically edge triggered since it is registered<br>as EDGE_BOTH in order to prevent the interrupt from firing when<br>the system is resuming.<br><br>And change the DSP interrupt to edge triggered since the kernel<br>is registering with IRQF_TRIGGER_RISING in order to prevent an<br>interrupt storm when it asserts.<br><br>BUG=b:35582164<br>TEST=manual testing on Eve:<br>1) ensure the headset codec sends interrupt on insert and remove<br>2) ensure there is only one interrupt counted when DSP asserts irq<br><br>Change-Id: I40a8ee667de653e4e70770cd96b6417442c1b0ec<br>Signed-off-by: Duncan Laurie <dlaurie@chromium.org><br>---<br>M src/mainboard/google/eve/devicetree.cb<br>M src/mainboard/google/eve/gpio.h<br>2 files changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/20433/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/google/eve/devicetree.cb b/src/mainboard/google/eve/devicetree.cb<br>index 81f235f..b6cb848 100644<br>--- a/src/mainboard/google/eve/devicetree.cb<br>+++ b/src/mainboard/google/eve/devicetree.cb<br>@@ -323,7 +323,7 @@<br>                    chip drivers/spi/acpi<br>                                 register "hid" = "ACPI_DT_NAMESPACE_HID"<br>                          register "compat_string" = ""realtek,rt5514""<br>-                          register "irq" = "ACPI_IRQ_LEVEL_HIGH(GPP_F10_IRQ)"<br>+                              register "irq" = "ACPI_IRQ_EDGE_HIGH(GPP_F10_IRQ)"<br>                                device spi 0 on end<br>                   end<br>           end # GSPI #0<br>diff --git a/src/mainboard/google/eve/gpio.h b/src/mainboard/google/eve/gpio.h<br>index cd0fe1d..4818697 100644<br>--- a/src/mainboard/google/eve/gpio.h<br>+++ b/src/mainboard/google/eve/gpio.h<br>@@ -128,7 +128,7 @@<br> /* ISH_I2C0_SCL */    PAD_CFG_NC(GPP_D6),<br> /* ISH_I2C1_SDA */        PAD_CFG_NC(GPP_D7),<br> /* ISH_I2C1_SCL */        PAD_CFG_NC(GPP_D8),<br>-/* ISH_SPI_CS# */ PAD_CFG_GPI(GPP_D9, NONE, PLTRST), /* HP_IRQ_GPIO */<br>+/* ISH_SPI_CS# */        PAD_CFG_GPI_INT(GPP_D9, NONE, PLTRST), /* HP_IRQ_GPIO */<br> /* ISH_SPI_CLK */    PAD_CFG_GPO(GPP_D10, 1, DEEP), /* SPKR_RST_L */<br> /* ISH_SPI_MISO */    PAD_CFG_GPI_APIC(GPP_D11, NONE, PLTRST), /* SPKR_INT_L */<br> /* ISH_SPI_MOSI */  PAD_CFG_TERM_GPO(GPP_D12, 1, 20K_PU, DEEP), /* EN_PP3300_DX_CAM */<br></pre><p>To view, visit <a href="https://review.coreboot.org/20433">change 20433</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20433"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I40a8ee667de653e4e70770cd96b6417442c1b0ec </div>
<div style="display:none"> Gerrit-Change-Number: 20433 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org> </div>