<p>Duncan Laurie has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20424">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboards: Remove unused EC event for thermal overload<br><br>The Chrome EC event for "thermal overload" was never implemented and<br>is being repurposed as the EC event mask is out of free bits.<br><br>Remove this from the boards that were enabling it.<br><br>BUG=b:36024430<br>TEST=build coreboot for affected boards<br><br>Change-Id: I6038389ad73cef8a57aec5041bbb9dea98ed2b6e<br>Signed-off-by: Duncan Laurie <dlaurie@chromium.org><br>---<br>M src/mainboard/google/auron/ec.h<br>M src/mainboard/google/chell/ec.h<br>M src/mainboard/google/cyan/ec.h<br>M src/mainboard/google/eve/ec.h<br>M src/mainboard/google/fizz/ec.h<br>M src/mainboard/google/glados/ec.h<br>M src/mainboard/google/lars/ec.h<br>M src/mainboard/google/link/ec.h<br>M src/mainboard/google/poppy/variants/baseboard/include/baseboard/ec.h<br>M src/mainboard/google/rambi/ec.h<br>M src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h<br>M src/mainboard/google/reef/variants/sand/include/variant/ec.h<br>M src/mainboard/google/slippy/ec.h<br>M src/mainboard/intel/kblrvp/ec.h<br>M src/mainboard/intel/kunimitsu/ec.h<br>M src/mainboard/intel/strago/ec.h<br>16 files changed, 0 insertions(+), 16 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/20424/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/google/auron/ec.h b/src/mainboard/google/auron/ec.h<br>index ef81d0c..d1a54a9 100644<br>--- a/src/mainboard/google/auron/ec.h<br>+++ b/src/mainboard/google/auron/ec.h<br>@@ -32,7 +32,6 @@<br>          EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY)           |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_STATUS)    |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_THRESHOLD) |\<br>-       EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_OVERLOAD)  |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_START)    |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP)     |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_CHARGER)       |\<br>diff --git a/src/mainboard/google/chell/ec.h b/src/mainboard/google/chell/ec.h<br>index ba9a450..fcb0a70 100644<br>--- a/src/mainboard/google/chell/ec.h<br>+++ b/src/mainboard/google/chell/ec.h<br>@@ -30,7 +30,6 @@<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY)           |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_STATUS)    |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_THRESHOLD) |\<br>-       EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_OVERLOAD)  |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_START)    |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP)     |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_CHARGER)       |\<br>diff --git a/src/mainboard/google/cyan/ec.h b/src/mainboard/google/cyan/ec.h<br>index 4e35ac9..1092977 100644<br>--- a/src/mainboard/google/cyan/ec.h<br>+++ b/src/mainboard/google/cyan/ec.h<br>@@ -35,7 +35,6 @@<br>    EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY)           |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_STATUS)    |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_THRESHOLD) |\<br>-       EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_OVERLOAD)  |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_START)    |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP)     |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_CHARGER)       |\<br>diff --git a/src/mainboard/google/eve/ec.h b/src/mainboard/google/eve/ec.h<br>index 0969da17..fa0dc21 100644<br>--- a/src/mainboard/google/eve/ec.h<br>+++ b/src/mainboard/google/eve/ec.h<br>@@ -31,7 +31,6 @@<br>       EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY)           |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_STATUS)    |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_THRESHOLD) |\<br>-       EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_OVERLOAD)  |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_START)    |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP)     |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_MKBP)              |\<br>diff --git a/src/mainboard/google/fizz/ec.h b/src/mainboard/google/fizz/ec.h<br>index 5a91713..b95a772 100644<br>--- a/src/mainboard/google/fizz/ec.h<br>+++ b/src/mainboard/google/fizz/ec.h<br>@@ -29,7 +29,6 @@<br>    EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY)           |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_STATUS)    |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_THRESHOLD) |\<br>-       EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_OVERLOAD)  |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_START)    |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP))<br> <br>diff --git a/src/mainboard/google/glados/ec.h b/src/mainboard/google/glados/ec.h<br>index ba9a450..fcb0a70 100644<br>--- a/src/mainboard/google/glados/ec.h<br>+++ b/src/mainboard/google/glados/ec.h<br>@@ -30,7 +30,6 @@<br>       EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY)           |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_STATUS)    |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_THRESHOLD) |\<br>-       EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_OVERLOAD)  |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_START)    |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP)     |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_CHARGER)       |\<br>diff --git a/src/mainboard/google/lars/ec.h b/src/mainboard/google/lars/ec.h<br>index ba9a450..fcb0a70 100644<br>--- a/src/mainboard/google/lars/ec.h<br>+++ b/src/mainboard/google/lars/ec.h<br>@@ -30,7 +30,6 @@<br>    EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY)           |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_STATUS)    |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_THRESHOLD) |\<br>-       EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_OVERLOAD)  |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_START)    |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP)     |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_CHARGER)       |\<br>diff --git a/src/mainboard/google/link/ec.h b/src/mainboard/google/link/ec.h<br>index af06772..1235d58 100644<br>--- a/src/mainboard/google/link/ec.h<br>+++ b/src/mainboard/google/link/ec.h<br>@@ -30,7 +30,6 @@<br>    EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_CRITICAL)  |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY)           |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_THRESHOLD) |\<br>-       EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_OVERLOAD)  |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_CHARGER))<br> <br> #define LINK_EC_SMI_EVENTS \<br>diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/ec.h<br>index 5d6cf4c..1312f63 100644<br>--- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/ec.h<br>+++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/ec.h<br>@@ -31,7 +31,6 @@<br>          EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY)           |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_STATUS)    |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_THRESHOLD) |\<br>-       EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_OVERLOAD)  |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_START)    |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP)     |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU)            |\<br>diff --git a/src/mainboard/google/rambi/ec.h b/src/mainboard/google/rambi/ec.h<br>index 6340b69..4eda997 100644<br>--- a/src/mainboard/google/rambi/ec.h<br>+++ b/src/mainboard/google/rambi/ec.h<br>@@ -33,7 +33,6 @@<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_CRITICAL)  |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY)           |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_THRESHOLD) |\<br>-       EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_OVERLOAD)  |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_START)    |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP)     |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_CHARGER)       |\<br>diff --git a/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h<br>index 47b193f..ad01519 100644<br>--- a/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h<br>+++ b/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h<br>@@ -29,7 +29,6 @@<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY)           |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_STATUS)    |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_THRESHOLD) |\<br>-       EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_OVERLOAD)  |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_START)    |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP)     |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_CHARGER)       |\<br>diff --git a/src/mainboard/google/reef/variants/sand/include/variant/ec.h b/src/mainboard/google/reef/variants/sand/include/variant/ec.h<br>index e4377c8..11232fe 100644<br>--- a/src/mainboard/google/reef/variants/sand/include/variant/ec.h<br>+++ b/src/mainboard/google/reef/variants/sand/include/variant/ec.h<br>@@ -29,7 +29,6 @@<br>    EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY)           |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_STATUS)    |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_THRESHOLD) |\<br>-       EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_OVERLOAD)  |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_START)    |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP)     |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_CHARGER)       |\<br>diff --git a/src/mainboard/google/slippy/ec.h b/src/mainboard/google/slippy/ec.h<br>index 22942ee..ae947a1 100644<br>--- a/src/mainboard/google/slippy/ec.h<br>+++ b/src/mainboard/google/slippy/ec.h<br>@@ -31,7 +31,6 @@<br>    EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_CRITICAL)  |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY)           |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_THRESHOLD) |\<br>-       EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_OVERLOAD)  |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_CHARGER))<br> <br> #define MAINBOARD_EC_SMI_EVENTS \<br>diff --git a/src/mainboard/intel/kblrvp/ec.h b/src/mainboard/intel/kblrvp/ec.h<br>index ff5533c..2498244 100644<br>--- a/src/mainboard/intel/kblrvp/ec.h<br>+++ b/src/mainboard/intel/kblrvp/ec.h<br>@@ -30,7 +30,6 @@<br>         EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY)           |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_STATUS)    |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_THRESHOLD) |\<br>-       EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_OVERLOAD)  |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_START)    |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP)     |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_CHARGER)       |\<br>diff --git a/src/mainboard/intel/kunimitsu/ec.h b/src/mainboard/intel/kunimitsu/ec.h<br>index ba9a450..fcb0a70 100644<br>--- a/src/mainboard/intel/kunimitsu/ec.h<br>+++ b/src/mainboard/intel/kunimitsu/ec.h<br>@@ -30,7 +30,6 @@<br>    EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY)           |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_STATUS)    |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_THRESHOLD) |\<br>-       EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_OVERLOAD)  |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_START)    |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP)     |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_CHARGER)       |\<br>diff --git a/src/mainboard/intel/strago/ec.h b/src/mainboard/intel/strago/ec.h<br>index 4e35ac9..1092977 100644<br>--- a/src/mainboard/intel/strago/ec.h<br>+++ b/src/mainboard/intel/strago/ec.h<br>@@ -35,7 +35,6 @@<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY)           |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_STATUS)    |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_THRESHOLD) |\<br>-       EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_OVERLOAD)  |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_START)    |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP)     |\<br>        EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_CHARGER)       |\<br></pre><p>To view, visit <a href="https://review.coreboot.org/20424">change 20424</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20424"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I6038389ad73cef8a57aec5041bbb9dea98ed2b6e </div>
<div style="display:none"> Gerrit-Change-Number: 20424 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org> </div>