<p>Patrick Georgi has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20390">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">abuild: give --silent the silent treatment<br><br>It's obsolete and without effect.<br><br>Change-Id: I17c1f8bffc2048a79de58cdc2a70651796db6ba6<br>Signed-off-by: Patrick Georgi <pgeorgi@chromium.org><br>---<br>M util/abuild/abuild<br>1 file changed, 8 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/20390/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/util/abuild/abuild b/util/abuild/abuild<br>index 6473fcf..d988164 100755<br>--- a/util/abuild/abuild<br>+++ b/util/abuild/abuild<br>@@ -75,10 +75,6 @@<br> # this can be changed to junit by -J<br> mode=text<br> <br>-# silent mode.. no compiler calls, only warnings in the log files.<br>-# this is disabled per default but can be enabled with -s<br>-silent=<br>-<br> # quiet mode: only print pass, failure, and 'skipped' messages<br> quiet=false<br> <br>@@ -274,10 +270,10 @@<br>    # shellcheck disable=SC2059<br>   printf "$configoptions" >> "${config_file}"<br> <br>-     yes "" 2>/dev/null | $MAKE oldconfig $silent "DOTCONFIG=${config_file}" "obj=${build_dir}" "objutil=$TARGET/sharedutils" &> "${build_dir}/config.log" ; \<br>+        yes "" 2>/dev/null | $MAKE oldconfig $verboseopt "DOTCONFIG=${config_file}" "obj=${build_dir}" "objutil=$TARGET/sharedutils" &> "${build_dir}/config.log" ; \<br>             CONFIG_OK=$?<br>  if [ $CONFIG_OK -eq 0 ]; then<br>-                $MAKE savedefconfig $silent DEFCONFIG="${defconfig_file}" DOTCONFIG="${config_file}" obj="${build_dir}" objutil="$TARGET/sharedutils" &>> "${build_dir}/config.log"<br>+              $MAKE savedefconfig $verboseopt DEFCONFIG="${defconfig_file}" DOTCONFIG="${config_file}" obj="${build_dir}" objutil="$TARGET/sharedutils" &>> "${build_dir}/config.log"<br>           return $?<br>     else<br>          return 1<br>@@ -344,8 +340,7 @@<br> <br>      CURR=$( pwd )<br>         #stime=`perl -e 'print time();' 2>/dev/null || date +%s`<br>-  # shellcheck disable=SC2086<br>-  eval $BUILDPREFIX $MAKE $silent DOTCONFIG="${build_dir}/config.build" obj="${build_dir}" objutil="$TARGET/sharedutils" BUILD_TIMELESS=$TIMELESS \<br>+      eval $BUILDPREFIX $MAKE $verboseopt DOTCONFIG="${build_dir}/config.build" obj="${build_dir}" objutil="$TARGET/sharedutils" BUILD_TIMELESS=$TIMELESS \<br>           &> "${build_dir}/make.log" ; \<br>               MAKE_FAILED=$?<br>        cp .xcompile "${build_dir}/xcompile.build"<br>@@ -547,7 +542,6 @@<br>     [-R|--root <path>]            Absolute path to coreboot sources<br>                                   (defaults to $ROOT)<br>     [--scan-build]                Use clang's static analyzer<br>-    [-s|--silent]                 Omit compiler calls in logs<br>     [--timeless]                  Generate timeless builds<br>     [-t|--target <vendor/board>]  Attempt to build target vendor/board only<br>     [-T|--test]                   Submit image(s) to automated test system<br>@@ -563,6 +557,7 @@<br>     [-V|--version]                Print version number and exit<br>     [-h|--help]                   Print this help and exit<br> <br>+    [-s|--silent]                 obsolete<br> __END_OF_HELP<br> }<br> <br>@@ -621,6 +616,7 @@<br> <br> chromeos=false<br> clean_work=false<br>+verboseopt='V=0'<br> customizing=""<br> configoptions=""<br> # testclass needs to be undefined if not used for variable expansion to work<br>@@ -632,7 +628,7 @@<br>                 -a|--all)       shift; buildall=true;;<br>                -d|--dir)       shift; configdir="$1"; shift;;<br>              -r|--remove)    shift; remove=true;;<br>-         -v|--verbose)   shift; verbose=true; silent='V=1';;<br>+          -v|--verbose)   shift; verbose=true; verboseopt='V=1';;<br>               -q|--quiet)     shift; quiet=true;;<br>           -V|--version)   shift; myversion; exit 0;;<br>            -h|--help)      shift; myversion; myhelp; exit 0;;<br>@@ -645,7 +641,8 @@<br>                       test "$1" == "1" && cpuconfig=" on 1 cpu"<br>                       expr "$1" : '-\?[0-9]\+$' > /dev/null && test "0$1" -gt 1 && cpuconfig=" on $1 cpus in parallel"<br>                     shift;;<br>-              -s|--silent)    shift; silent="-s";;<br>+               # obsolete option<br>+            -s|--silent)    shift;;<br>               --scan-build)   shift<br>                         scanbuild=true<br>                        customizing="${customizing}, scan-build"<br></pre><p>To view, visit <a href="https://review.coreboot.org/20390">change 20390</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20390"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I17c1f8bffc2048a79de58cdc2a70651796db6ba6 </div>
<div style="display:none"> Gerrit-Change-Number: 20390 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Georgi <pgeorgi@google.com> </div>