<p>Matt DeVillier has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20395">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">[WIP] nb/haswell: use GMA common OpRegion<br><br>Add update_igd_opregion() to handle platform-specific<br>mailbox data.<br><br>Change-Id: Id1d8829d8e8542a165d5eb57725f211c4ae56cf8<br>Signed-off-by: Matt DeVillier <matt.devillier@gmail.com><br>---<br>M src/northbridge/intel/haswell/Kconfig<br>M src/northbridge/intel/haswell/gma.c<br>2 files changed, 36 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/20395/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/northbridge/intel/haswell/Kconfig b/src/northbridge/intel/haswell/Kconfig<br>index 90f8774..d6cf0d7 100644<br>--- a/src/northbridge/intel/haswell/Kconfig<br>+++ b/src/northbridge/intel/haswell/Kconfig<br>@@ -17,7 +17,7 @@<br>         bool<br>  select CPU_INTEL_HASWELL<br>      select NORTHBRIDGE_INTEL_COMMON_MRC_CACHE<br>-    select NORTHBRIDGE_INTEL_COMMON_GMA_OPREGION<br>+ select INTEL_GMA_OPREGION<br>     select INTEL_DDI<br>      select INTEL_GMA_ACPI<br>         select RELOCATABLE_RAMSTAGE<br>diff --git a/src/northbridge/intel/haswell/gma.c b/src/northbridge/intel/haswell/gma.c<br>index 0dcd82a..ef80f77 100644<br>--- a/src/northbridge/intel/haswell/gma.c<br>+++ b/src/northbridge/intel/haswell/gma.c<br>@@ -23,7 +23,7 @@<br> #include <drivers/intel/gma/i915_reg.h><br> #include <drivers/intel/gma/i915.h><br> #include <cpu/intel/haswell/haswell.h><br>-#include <northbridge/intel/common/gma_opregion.h><br>+#include <drivers/intel/gma/opregion.h><br> #include <stdlib.h><br> #include <string.h><br> #include <southbridge/intel/lynxpoint/nvs.h><br>@@ -524,6 +524,39 @@<br>  drivers_intel_gma_displays_ssdt_generate(gfx);<br> }<br> <br>+/* Initialize IGD OpRegion, called from ACPI code */<br>+static void<br>+update_igd_opregion(igd_opregion_t *opregion)<br>+{<br>+       /* We just assume we're mobile for now */<br>+        opregion->header.mailboxes = MAILBOXES_MOBILE;<br>+<br>+ //From Intel OpRegion reference doc<br>+  opregion->header.pcon = 279;<br>+<br>+   // Initialize Mailbox 1<br>+      opregion->mailbox1.clid = 1;<br>+<br>+   /* Initialize Mailbox 3 */<br>+   opregion->mailbox3.bclp = IGD_BACKLIGHT_BRIGHTNESS;<br>+       opregion->mailbox3.pfit = IGD_FIELD_VALID | IGD_PFIT_STRETCH;<br>+     opregion->mailbox3.pcft = 0; /* should be (IMON << 1) & 0x3e */<br>+ opregion->mailbox3.cblv = IGD_FIELD_VALID | IGD_INITIAL_BRIGHTNESS;<br>+       opregion->mailbox3.bclm[0] = IGD_WORD_FIELD_VALID + 0x0000;<br>+       opregion->mailbox3.bclm[1] = IGD_WORD_FIELD_VALID + 0x0a19;<br>+       opregion->mailbox3.bclm[2] = IGD_WORD_FIELD_VALID + 0x1433;<br>+       opregion->mailbox3.bclm[3] = IGD_WORD_FIELD_VALID + 0x1e4c;<br>+       opregion->mailbox3.bclm[4] = IGD_WORD_FIELD_VALID + 0x2866;<br>+       opregion->mailbox3.bclm[5] = IGD_WORD_FIELD_VALID + 0x327f;<br>+       opregion->mailbox3.bclm[6] = IGD_WORD_FIELD_VALID + 0x3c99;<br>+       opregion->mailbox3.bclm[7] = IGD_WORD_FIELD_VALID + 0x46b2;<br>+       opregion->mailbox3.bclm[8] = IGD_WORD_FIELD_VALID + 0x50cc;<br>+       opregion->mailbox3.bclm[9] = IGD_WORD_FIELD_VALID + 0x5ae5;<br>+       opregion->mailbox3.bclm[10] = IGD_WORD_FIELD_VALID + 0x64ff;<br>+<br>+   intel_gma_opregion_register((uintptr_t)opregion);<br>+}<br>+<br> static unsigned long<br> gma_write_acpi_tables(struct device *const dev,<br>                   unsigned long current,<br>@@ -534,6 +567,7 @@<br> <br>  if (init_igd_opregion(opregion) != CB_SUCCESS)<br>                return current;<br>+      update_igd_opregion(opregion);<br> <br>     current += sizeof(igd_opregion_t);<br> <br></pre><p>To view, visit <a href="https://review.coreboot.org/20395">change 20395</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20395"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id1d8829d8e8542a165d5eb57725f211c4ae56cf8 </div>
<div style="display:none"> Gerrit-Change-Number: 20395 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com> </div>