<p>Martin Roth has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20340">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src/ec: add IS_ENABLED() around Kconfig symbol references<br><br>Change-Id: Ic2cdfa08cdae9f698eb2f8fa4c4ae061f1a7d903<br>Signed-off-by: Martin Roth <martinroth@google.com><br>---<br>M src/ec/google/chromeec/acpi/ec.asl<br>M src/ec/google/chromeec/ec.c<br>M src/ec/google/chromeec/ec_lpc.c<br>M src/ec/quanta/ene_kb3940q/ec.c<br>4 files changed, 7 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/20340/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl<br>index 43520f7..a532492 100644<br>--- a/src/ec/google/chromeec/acpi/ec.asl<br>+++ b/src/ec/google/chromeec/acpi/ec.asl<br>@@ -56,7 +56,7 @@<br>             TBMD, 1,        // Tablet mode<br>        }<br> <br>-#if CONFIG_EC_GOOGLE_CHROMEEC_ACPI_MEMMAP<br>+#if IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC_ACPI_MEMMAP)<br>      OperationRegion (EMEM, EmbeddedControl,<br>                        EC_ACPI_MEM_MAPPED_BEGIN, EC_ACPI_MEM_MAPPED_SIZE)<br>   Field (EMEM, ByteAcc, Lock, Preserve)<br>diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c<br>index e622410..de17495 100644<br>--- a/src/ec/google/chromeec/ec.c<br>+++ b/src/ec/google/chromeec/ec.c<br>@@ -466,7 +466,7 @@<br> <br> void google_chromeec_log_events(u32 mask)<br> {<br>-#if CONFIG_ELOG<br>+#if IS_ENABLED(CONFIG_ELOG)<br>    u8 event;<br>     u32 wake_mask;<br> <br>diff --git a/src/ec/google/chromeec/ec_lpc.c b/src/ec/google/chromeec/ec_lpc.c<br>index 9ead8c8..42a18e4 100644<br>--- a/src/ec/google/chromeec/ec_lpc.c<br>+++ b/src/ec/google/chromeec/ec_lpc.c<br>@@ -38,7 +38,7 @@<br> {<br>         int i;<br> <br>-#if CONFIG_EC_GOOGLE_CHROMEEC_MEC<br>+#if IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC_MEC)<br>         /* Access desired range though EMI interface */<br>       if (port >= MEC_EMI_RANGE_START && port <= MEC_EMI_RANGE_END) {<br>                 mec_io_bytes(0, port, length, dest, csum);<br>@@ -73,7 +73,7 @@<br> {<br>     int i;<br> <br>-#if CONFIG_EC_GOOGLE_CHROMEEC_MEC<br>+#if IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC_MEC)<br>         /* Access desired range though EMI interface */<br>       if (port >= MEC_EMI_RANGE_START && port <= MEC_EMI_RANGE_END) {<br>                 mec_io_bytes(1, port, length, msg, csum);<br>@@ -124,7 +124,7 @@<br>                                            EC_LPC_CMDR_BUSY, 0);<br> }<br> <br>-#if CONFIG_EC_GOOGLE_CHROMEEC_ACPI_MEMMAP<br>+#if IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC_ACPI_MEMMAP)<br> /* Read memmap data through ACPI port 66/62 */<br> static int read_memmap(u8 *data, u8 offset)<br> {<br>@@ -158,7 +158,7 @@<br> {<br>      u8 id1, id2, flags;<br> <br>-#if CONFIG_EC_GOOGLE_CHROMEEC_ACPI_MEMMAP<br>+#if IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC_ACPI_MEMMAP)<br>    if (read_memmap(&id1, EC_MEMMAP_ID) ||<br>        read_memmap(&id2, EC_MEMMAP_ID + 1) ||<br>            read_memmap(&flags, EC_MEMMAP_HOST_CMD_FLAGS)) {<br>diff --git a/src/ec/quanta/ene_kb3940q/ec.c b/src/ec/quanta/ene_kb3940q/ec.c<br>index 8558d3d..b25a51b 100644<br>--- a/src/ec/quanta/ene_kb3940q/ec.c<br>+++ b/src/ec/quanta/ene_kb3940q/ec.c<br>@@ -129,7 +129,7 @@<br> #ifndef __SMM__<br> static void ene_kb3940q_log_events(void)<br> {<br>-#if CONFIG_ELOG<br>+#if IS_ENABLED(CONFIG_ELOG)<br>       u8 reason = ec_mem_read(EC_SHUTDOWN_REASON);<br>  if (reason)<br>           elog_add_event_byte(ELOG_TYPE_EC_SHUTDOWN, reason);<br></pre><p>To view, visit <a href="https://review.coreboot.org/20340">change 20340</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20340"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic2cdfa08cdae9f698eb2f8fa4c4ae061f1a7d903 </div>
<div style="display:none"> Gerrit-Change-Number: 20340 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>