<p>Lee Leahy has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20322">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">libpayload: Enable building libpayload with march=i586<br><br>Add a Kconfig value to enable building libpayload with the 586 compiler.<br>Update the cross compiler script to add the Kconfig value name that is<br>used when libpayload builds.<br><br>The Quark SOC does not support some of the instructions generated with<br>the 686 compiler (e.g. CMOV).  Success occurs when<br>payloads/libpayload/build/config.h indicates that<br>CONFIG_LP_USE_MARCH_586=1.<br><br>TEST=Build and run on Galileo Gen2.<br><br>Change-Id: I04907e9a38ee139bae2e8b227821f54614707c25<br>Signed-off-by: Lee Leahy <Leroy.P.Leahy@intel.com><br>---<br>M payloads/libpayload/Kconfig<br>M util/xcompile/xcompile<br>2 files changed, 13 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/20322/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/payloads/libpayload/Kconfig b/payloads/libpayload/Kconfig<br>index dcb1f4e..5a5bce2 100644<br>--- a/payloads/libpayload/Kconfig<br>+++ b/payloads/libpayload/Kconfig<br>@@ -157,6 +157,14 @@<br> <br> endmenu<br> <br>+config USE_MARCH_586<br>+      bool "Use march=586 qualifier to build"<br>+    default n<br>+    depends on ARCH_X86<br>+  help<br>+   Allow a platform or processor to select to be compiled using<br>+         the '-march=i586' option instead of the typical '-march=i686'<br>+<br> menu "Standard Libraries"<br> <br> config LIBC<br>diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile<br>index 347ae8e..7b66247 100755<br>--- a/util/xcompile/xcompile<br>+++ b/util/xcompile/xcompile<br>@@ -238,7 +238,11 @@<br> ifeq (\$(CONFIG_USE_MARCH_586),y)<br>  GCC_CFLAGS_${TARCH} += -march=i586<br> else<br>-    GCC_CFLAGS_${TARCH} += -march=i686<br>+   ifeq (\$(CONFIG_LP_USE_MARCH_586),y)<br>+         GCC_CFLAGS_${TARCH} += -march=i586<br>+   else<br>+         GCC_CFLAGS_${TARCH} += -march=i686<br>+   endif<br> endif<br> EOF<br> fi<br></pre><p>To view, visit <a href="https://review.coreboot.org/20322">change 20322</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20322"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I04907e9a38ee139bae2e8b227821f54614707c25 </div>
<div style="display:none"> Gerrit-Change-Number: 20322 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Lee Leahy <leroy.p.leahy@intel.com> </div>