<p>Patrick Rudolph has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20286">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nb/intel/fsp_sandybridge/gma: Set ASLS on S3 resume<br><br>Set ASLS on S3 resume, too.<br>Use new GMA driver method to set ASLS.<br><br>Change-Id: I772d680774890c32ca6dc9b1e2143b3ab3bf6513<br>Signed-off-by: Patrick Rudolph <siro@das-labor.org><br>---<br>M src/northbridge/intel/fsp_sandybridge/gma.c<br>1 file changed, 20 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/20286/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/northbridge/intel/fsp_sandybridge/gma.c b/src/northbridge/intel/fsp_sandybridge/gma.c<br>index 8e2d968..9cf2537 100644<br>--- a/src/northbridge/intel/fsp_sandybridge/gma.c<br>+++ b/src/northbridge/intel/fsp_sandybridge/gma.c<br>@@ -104,6 +104,25 @@<br>    outw(DEFAULT_PMBASE + GPE0_EN, reg16);<br> }<br> <br>+static void gma_init(struct device *dev)<br>+{<br>+ pci_dev_init(dev);<br>+<br>+        if (acpi_is_wakeup_s3()) {<br>+           /* GNVS has been already set up */<br>+           const global_nvs_t *gnvs = cbmem_find(CBMEM_ID_ACPI_GNVS);<br>+<br>+                if (gnvs && gnvs->aslb) {<br>+                 gma_enable_swsci();<br>+<br>+                       /* Provide ACPI OpRegion address */<br>+                  intel_gma_opregion_register((uintptr_t)gnvs->aslb);<br>+               } else {<br>+                     printk(BIOS_ERR, "Error: GNVS table not found.\n");<br>+                }<br>+    }<br>+}<br>+<br> static unsigned long<br> gma_write_acpi_tables(struct device *const dev,<br>                   unsigned long current,<br>@@ -141,7 +160,7 @@<br>     .set_resources          = pci_dev_set_resources,<br>      .enable_resources       = pci_dev_enable_resources,<br>   .acpi_fill_ssdt_generator = gma_ssdt,<br>-        .init                   = pci_dev_init,<br>+      .init                   = gma_init,<br>   .scan_bus               = 0,<br>  .enable                 = 0,<br>  .ops_pci                = &gma_pci_ops,<br></pre><p>To view, visit <a href="https://review.coreboot.org/20286">change 20286</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20286"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I772d680774890c32ca6dc9b1e2143b3ab3bf6513 </div>
<div style="display:none"> Gerrit-Change-Number: 20286 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <siro@das-labor.org> </div>