<p>Patrick Rudolph has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/20283">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">nb/intel/common/gma_opregion: Use new method to update ASLS<br><br>Use new GMA driver method to set ASLS.<br><br>Change-Id: I872ff86a778497df76ad7f9b1b6910c4e7c5941f<br>Signed-off-by: Patrick Rudolph <siro@das-labor.org><br>---<br>M src/northbridge/intel/common/gma_opregion.c<br>1 file changed, 1 insertion(+), 13 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/20283/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/northbridge/intel/common/gma_opregion.c b/src/northbridge/intel/common/gma_opregion.c<br>index 7d4c3f1..f6e05b9 100644<br>--- a/src/northbridge/intel/common/gma_opregion.c<br>+++ b/src/northbridge/intel/common/gma_opregion.c<br>@@ -79,8 +79,6 @@<br> enum cb_err init_igd_opregion(igd_opregion_t *opregion)<br> {<br>      enum cb_err ret;<br>-     device_t igd;<br>-        u16 reg16;<br> <br>         memset((void *)opregion, 0, sizeof(igd_opregion_t));<br> <br>@@ -119,17 +117,7 @@<br>         if (ret != CB_SUCCESS)<br>                return ret;<br> <br>-       /* TODO This needs to happen in S3 resume, too.<br>-       * Maybe it should move to the finalize handler<br>-       */<br>-  igd = dev_find_slot(0, PCI_DEVFN(0x2, 0));<br>-   pci_write_config32(igd, ASLS, (u32)opregion);<br>-<br>-     /* Intel's Windows driver relies on this: */<br>-     reg16 = pci_read_config16(igd, SWSCI);<br>-       reg16 &= ~GSSCIE;<br>-        reg16 |= SMISCISEL;<br>-  pci_write_config16(igd, SWSCI, reg16);<br>+       intel_gma_opregion_register((uintptr_t)opregion);<br> <br>  return CB_SUCCESS;<br> }<br></pre><p>To view, visit <a href="https://review.coreboot.org/20283">change 20283</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/20283"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I872ff86a778497df76ad7f9b1b6910c4e7c5941f </div>
<div style="display:none"> Gerrit-Change-Number: 20283 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Rudolph <siro@das-labor.org> </div>