ramstage/x86emu doesn't build

[Martin Kepplinger]

Hi,

Before I dig in without knowing the code: x86emu currently ( 
0987e43aa05bfbafbfdd4952638b79a5084369f8 )
doesn't build:

In file included from src/device/oprom/x86emu/x86emui.h:65,
                  from src/device/oprom/x86emu/debug.c:40:
src/device/oprom/x86emu/debug.c: In function 'x86emu_dump_regs':
src/device/oprom/x86emu/debug.h:46:22: error: implicit declaration of 
function 'printk'; did you mean 'printf'? 
[-Werror=implicit-function-declaration]
  #define printf(x...) printk(BIOS_DEBUG, x)
                       ^~~~~~
src/device/oprom/x86emu/debug.c:366:5: note: in expansion of macro 
'printf'
      printf("\tAX=%04x  ", M.x86.R_AX );
      ^~~~~~

I append the config. Also, there's noone in MAINTAINER for it, and 
appearently it's not build-tested :(

thanks

martin

[Zeh, Werner]

Looks like console.h was removed in https://review.coreboot.org/c/coreboot/+/32214
We had a few such "accidents" in the past few days.
@Elyes: want to fix?

Werner
---------------------------------------------------------------------------------------------
Hi,

Before I dig in without knowing the code: x86emu currently (
0987e43aa05bfbafbfdd4952638b79a5084369f8 ) doesn't build:

In file included from src/device/oprom/x86emu/x86emui.h:65,
                  from src/device/oprom/x86emu/debug.c:40:
src/device/oprom/x86emu/debug.c: In function 'x86emu_dump_regs':
src/device/oprom/x86emu/debug.h:46:22: error: implicit declaration of function 'printk'; did you mean 'printf'? 
[-Werror=implicit-function-declaration]
  #define printf(x...) printk(BIOS_DEBUG, x)
                       ^~~~~~
src/device/oprom/x86emu/debug.c:366:5: note: in expansion of macro 'printf'
      printf("\tAX=%04x  ", M.x86.R_AX );
      ^~~~~~

I append the config. Also, there's noone in MAINTAINER for it, and appearently it's not build-tested :(

thanks

martin

[Patrick Georgi]

There was some recent cleanup on console.h includes that makes printk only
visible where we thought it was needed.
A change to add an include for console/console.h to resolve the issue here.
Cc'ing Elyes since that's his effort.

As you correctly noticed, x86emu isn't build-tested by default: If you
want, you could contribute a patch to add your config to configs/, which
makes it build tested by default to avoid future regressions in the x86emu
code.

Thanks,
Patrick

Am Do., 25. Apr. 2019 um 09:50 Uhr schrieb Martin Kepplinger <
[e-mail]>:
> Hi,
>
> Before I dig in without knowing the code: x86emu currently (
> 0987e43aa05bfbafbfdd4952638b79a5084369f8 )
> doesn't build:
>
> In file included from src/device/oprom/x86emu/x86emui.h:65,
>                   from src/device/oprom/x86emu/debug.c:40:
> src/device/oprom/x86emu/debug.c: In function 'x86emu_dump_regs':
> src/device/oprom/x86emu/debug.h:46:22: error: implicit declaration of
> function 'printk'; did you mean 'printf'?
> [-Werror=implicit-function-declaration]
>   #define printf(x...) printk(BIOS_DEBUG, x)
>                        ^~~~~~
> src/device/oprom/x86emu/debug.c:366:5: note: in expansion of macro
> 'printf'
>       printf("\tAX=%04x  ", M.x86.R_AX );
>       ^~~~~~
>
> I append the config. Also, there's noone in MAINTAINER for it, and
> appearently it's not build-tested :(
>
> thanks
>                               martin
>
> coreboot mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[Martin Kepplinger]

On 25.04.19 12:23, Patrick Georgi via coreboot wrote:
> There was some recent cleanup on console.h includes that makes printk
> only visible where we thought it was needed.
> A change to add an include for console/console.h to resolve the issue
> here. Cc'ing Elyes since that's his effort.
>
> As you correctly noticed, x86emu isn't build-tested by default: If you
> want, you could contribute a patch to add your config to configs/, which
> makes it build tested by default to avoid future regressions in the
> x86emu code.

The initial failure is fixed, thanks. Adding a config that uses x86emu
isn't trivial in this case since x86emu is used to run a nonfree vbios
option rom that isn't part of our blobs repo...

thanks

martin

[Nico Huber]

On 02.05.19 08:10, Martin Kepplinger wrote:
> On 25.04.19 12:23, Patrick Georgi via coreboot wrote:
> > There was some recent cleanup on console.h includes that makes printk
> > only visible where we thought it was needed.
> > A change to add an include for console/console.h to resolve the issue
> > here. Cc'ing Elyes since that's his effort.
> >
> > As you correctly noticed, x86emu isn't build-tested by default: If you
> > want, you could contribute a patch to add your config to configs/, which
> > makes it build tested by default to avoid future regressions in the
> > x86emu code.
>
> The initial failure is fixed, thanks. Adding a config that uses x86emu
> isn't trivial in this case since x86emu is used to run a nonfree vbios
> option rom that isn't part of our blobs repo...

The options to run OpROMs are independent from those that add binaries.
This simple config works for instance:

CONFIG_VENDOR_ESD=y
    CONFIG_PCI_OPTION_ROM_RUN_YABEL=y

Nico